Skip to content

feat(formatter): Support Vitest test functions#17340

Merged
graphite-app[bot] merged 1 commit intomainfrom
12-24-feat_formatter_support_vitest_test_functions
Dec 25, 2025
Merged

feat(formatter): Support Vitest test functions#17340
graphite-app[bot] merged 1 commit intomainfrom
12-24-feat_formatter_support_vitest_test_functions

Conversation

@leaysgur
Copy link
Member

@leaysgur leaysgur commented Dec 24, 2025

If approved, I may send a PR to Prettier too.

@github-actions github-actions bot added A-formatter Area - Formatter C-enhancement Category - New feature or request labels Dec 24, 2025
Copy link
Member Author

leaysgur commented Dec 24, 2025


How to use the Graphite Merge Queue

Add either label to this PR to merge it via the merge queue:

  • 0-merge - adds this PR to the back of the merge queue
  • hotfix - for urgent hot fixes, skip the queue and merge this PR next

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@codspeed-hq
Copy link

codspeed-hq bot commented Dec 24, 2025

CodSpeed Performance Report

Merging #17340 will not alter performance

Comparing 12-24-feat_formatter_support_vitest_test_functions (d36b956) with 12-24-fix_formatter_fix_deno_to_not_detect_as_test_functions (f89d9c8)

Summary

✅ 38 untouched
⏩ 7 skipped1

Footnotes

  1. 7 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@leaysgur leaysgur marked this pull request as ready for review December 25, 2025 00:19
@leaysgur leaysgur requested a review from Dunqing as a code owner December 25, 2025 00:19
@Dunqing Dunqing added the 0-merge Merge with Graphite Merge Queue label Dec 25, 2025
Copy link
Member

Dunqing commented Dec 25, 2025

Merge activity

If approved, I may send a PR to Prettier too.
graphite-app bot pushed a commit that referenced this pull request Dec 25, 2025
Fixes #17272

---

This PR adds our missing test functions vs Prettier.

However, Prettier only supports:

https://github.com/prettier/prettier/blob/cd0c3292d303f3e0cbab2530045cfc06d6609d25/src/language-js/utilities/index.js#L298-L325

And we(Biome) already support extra variants like `Deno.test()`.

I also noticed that Biome has added more variants, such as Vitest test functions.
I think it's OK to follow these, but it means the difference with Prettier becomes wider.

How do you think? (draft: #17340)
@graphite-app graphite-app bot force-pushed the 12-24-fix_formatter_fix_deno_to_not_detect_as_test_functions branch from f89d9c8 to e836f37 Compare December 25, 2025 01:17
@graphite-app graphite-app bot force-pushed the 12-24-feat_formatter_support_vitest_test_functions branch from d36b956 to 7c3dae3 Compare December 25, 2025 01:18
@graphite-app graphite-app bot removed the 0-merge Merge with Graphite Merge Queue label Dec 25, 2025
Base automatically changed from 12-24-fix_formatter_fix_deno_to_not_detect_as_test_functions to main December 25, 2025 01:25
@graphite-app graphite-app bot merged commit 7c3dae3 into main Dec 25, 2025
21 checks passed
@graphite-app graphite-app bot deleted the 12-24-feat_formatter_support_vitest_test_functions branch December 25, 2025 01:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-formatter Area - Formatter C-enhancement Category - New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants